Bug 215963 - Move PerformanceMonitor related DeprecatedGlobalSettings to Settings
Summary: Move PerformanceMonitor related DeprecatedGlobalSettings to Settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks: 250192
  Show dependency tree / graph
 
Reported: 2020-08-28 17:58 PDT by Sam Weinig
Modified: 2023-01-06 14:26 PST (History)
2 users (show)

See Also:

Attachments
Patch (10.87 KB, patch)
2020-08-28 18:46 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (10.87 KB, patch)
2020-08-29 08:51 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-08-28 17:58:48 PDT 
The PerformanceMonitor related uses of DeprecatedGlobalSettings can easily be moved to Settings, as PerformanceMonitor has a Page reference. None of these are actually settings in the traditional sense right now, as they are immutable, so we could just make them #defines, but given how easy it is move them to Settings, I think that makes the most sense here.
Comment 1 Sam Weinig 2020-08-28 18:46:56 PDT 
Created attachment 407521 [details]
Patch
Comment 2 Sam Weinig 2020-08-29 08:51:40 PDT 
Created attachment 407540 [details]
Patch
Comment 3 EWS 2020-08-29 17:05:08 PDT 
Committed r266328: <https://trac.webkit.org/changeset/266328>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407540 [details].
Comment 4 Radar WebKit Bug Importer 2020-08-29 17:06:15 PDT 
<rdar://problem/68009122>