WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
215963
Move PerformanceMonitor related DeprecatedGlobalSettings to Settings
https://bugs.webkit.org/show_bug.cgi?id=215963
Summary
Move PerformanceMonitor related DeprecatedGlobalSettings to Settings
Sam Weinig
Reported
2020-08-28 17:58:48 PDT
The PerformanceMonitor related uses of DeprecatedGlobalSettings can easily be moved to Settings, as PerformanceMonitor has a Page reference. None of these are actually settings in the traditional sense right now, as they are immutable, so we could just make them #defines, but given how easy it is move them to Settings, I think that makes the most sense here.
Attachments
Patch
(10.87 KB, patch)
2020-08-28 18:46 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(10.87 KB, patch)
2020-08-29 08:51 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2020-08-28 18:46:56 PDT
Created
attachment 407521
[details]
Patch
Sam Weinig
Comment 2
2020-08-29 08:51:40 PDT
Created
attachment 407540
[details]
Patch
EWS
Comment 3
2020-08-29 17:05:08 PDT
Committed
r266328
: <
https://trac.webkit.org/changeset/266328
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 407540
[details]
.
Radar WebKit Bug Importer
Comment 4
2020-08-29 17:06:15 PDT
<
rdar://problem/68009122
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug