Bug 215949 - [ews] Notify bot watchers about pre-existing and flaky test failures for API tests
Summary: [ews] Notify bot watchers about pre-existing and flaky test failures for API ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-28 13:34 PDT by Aakash Jain
Modified: 2020-09-04 11:52 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.92 KB, patch)
2020-09-04 04:36 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-08-28 13:34:35 PDT 
Notify bot watchers about pre-existing and flaky test failures for API tests found in EWS.
Comment 1 Aakash Jain 2020-09-04 04:36:45 PDT 
Created attachment 407957 [details]
Patch
Comment 2 Jonathan Bedard 2020-09-04 11:18:04 PDT 
Comment on attachment 407957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407957&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:2606
> +    def send_email_for_flaky_failure(self, test_name):

I'm find with this as-is, but it does seem like we're duplicating quite a bit of code for layout test emails.

Seems like we might want a base "AnalyzeTestResults" step with a "send_email_for_flaky_failure(self, test_name):" function that pulls from a "suite" variable
Comment 3 Aakash Jain 2020-09-04 11:43:35 PDT 
Yeah, will do that in a separate patch.
Comment 4 EWS 2020-09-04 11:51:03 PDT 
Committed r266626: <https://trac.webkit.org/changeset/266626>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407957 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-04 11:52:19 PDT 
<rdar://problem/68358168>