WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
215943
WKUIDelegate's contextMenuConfigurationForElement API method isn't called for images
https://bugs.webkit.org/show_bug.cgi?id=215943
Summary
WKUIDelegate's contextMenuConfigurationForElement API method isn't called for...
Ali Juma
Reported
2020-08-28 12:15:49 PDT
The public API method -[WKUIDelegate webView:contextMenuConfigurationForElement:completionHandler] is only called for links, not for images. The SPI version (-[WKUIDelegate _webView:contextMenuConfigurationForElement:completionHandler]) does get called for images. This means that WKWebView embedders cannot easily customize the context menu shown for images. The logic for this is in -[WKContentViewInteraction continueContextMenuInteraction:], which does: if (_positionInformation.isLink && [uiDelegate respondsToSelector:@selector(webView:contextMenuConfigurationForElement:completionHandler:)]) { ..... } else if ([uiDelegate respondsToSelector:@selector(_webView:contextMenuConfigurationForElement:completionHandler:)]) { ..... } Could we change the first condition to also include |_positionInformation.isImage|?
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-08-29 11:25:40 PDT
<
rdar://problem/68000830
>
Alex Christensen
Comment 2
2020-08-31 18:19:46 PDT
This API was designed to be a replacement for the API it deprecated without substantial changes. We are considering improving the context menu API, and this input is noted.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug