Bug 215935 - Resync web-platform-tests/webaudio from upstream
Summary: Resync web-platform-tests/webaudio from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency treegraph
 
Reported: 2020-08-28 10:46 PDT by Chris Dumez
Modified: 2020-08-31 12:54 PDT (History)
13 users (show)

See Also:


Attachments
Patch (59.13 KB, patch)
2020-08-28 10:50 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-28 10:46:17 PDT
Resync web-platform-tests/webaudio from upstream.
Comment 1 Chris Dumez 2020-08-28 10:50:05 PDT
Created attachment 407485 [details]
Patch
Comment 2 Sam Weinig 2020-08-28 11:22:21 PDT
Comment on attachment 407485 [details]
Patch

rs=me
Comment 3 EWS 2020-08-28 11:52:57 PDT
Committed r266289: <https://trac.webkit.org/changeset/266289>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407485 [details].
Comment 4 Radar WebKit Bug Importer 2020-08-28 11:53:15 PDT
<rdar://problem/67953231>
Comment 5 Truitt Savell 2020-08-31 12:49:59 PDT
After the resync in r266289 this test:
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum.html

began flakily failing very often due to an additional Console Message:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebaudio%2Fthe-audio-api%2Fthe-analysernode-interface%2Ftest-analyser-minimum.html

Diff:
--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-actual.txt
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: Error: assert_true: silent input process -Infinity in decibel bins expected true got false
 CONSOLE MESSAGE: Error: assert_true: silent input process -Infinity in decibel bins expected true got false
 
 FAIL Test AnalyserNode when the input is silent Error: assert_true: silent input process -Infinity in decibel bins expected true got false
Comment 6 Chris Dumez 2020-08-31 12:54:28 PDT
(In reply to Truitt Savell from comment #5)
> After the resync in r266289 this test:
> imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-
> interface/test-analyser-minimum.html
> 
> began flakily failing very often due to an additional Console Message:
> https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-
> platform-tests%2Fwebaudio%2Fthe-audio-api%2Fthe-analysernode-
> interface%2Ftest-analyser-minimum.html
> 
> Diff:
> ---
> /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/
> imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-
> interface/test-analyser-minimum-expected.txt
> +++
> /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/
> imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-
> interface/test-analyser-minimum-actual.txt
> @@ -1,3 +1,4 @@
> +CONSOLE MESSAGE: Error: assert_true: silent input process -Infinity in
> decibel bins expected true got false
>  CONSOLE MESSAGE: Error: assert_true: silent input process -Infinity in
> decibel bins expected true got false
>  
>  FAIL Test AnalyserNode when the input is silent Error: assert_true: silent
> input process -Infinity in decibel bins expected true got false

<https://trac.webkit.org/changeset/266366> should address this.