Bug 21593 - add multiple-file support to HTMLFormElement
Summary: add multiple-file support to HTMLFormElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-14 11:50 PDT by Darin Adler
Modified: 2008-10-14 12:19 PDT (History)
2 users (show)

See Also:


Attachments
patch (11.75 KB, patch)
2008-10-14 12:00 PDT, Darin Adler
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-10-14 11:50:20 PDT
Change the form-submission code in HTMLFormElement to support multiple files. There's no way to test this yet since the HTMLInputElement doesn't yet support selecting multiple files, but I will test that it doesn't cause any regressions or problems for the 0 file or 1 file case.
Comment 1 Darin Adler 2008-10-14 12:00:06 PDT
Created attachment 24344 [details]
patch
Comment 2 Darin Adler 2008-10-14 12:00:43 PDT
(In reply to comment #0)
> I will test that it doesn't cause any regressions or problems for the 0 file or 1 file case.

I ran the entire regression test suite and that worked fine. I'll do some manual testing now.
Comment 3 Sam Weinig 2008-10-14 12:08:13 PDT
Comment on attachment 24344 [details]
patch

Awesome patch.  I am a little concerned about the removal of copyright though.  How did you verify that those contributors that were removed had no edits to the contents of the files?

r=me if you have a good reason for doing so.
Comment 4 Darin Adler 2008-10-14 12:12:55 PDT
(In reply to comment #3)
> How did you verify that those contributors that were removed had no edits to
> the contents of the files?

1) I wrote all the code for those classes myself.
2) You can easily see by the ChangeLog that code was added in 2005; the other copyrights were from long before 2005.
Comment 5 Darin Adler 2008-10-14 12:19:48 PDT
http://trac.webkit.org/changeset/37589