Why is this disabled? It doesn't seem to pull additional build-time dependencies here.
I think we should enable this by default. For the WPE port I think it is
fine to let the default implementation be a stub that does nothing (so
not even libnotify is needed at build time) so embedders can decide how
to show notifications connecting to the WebKitWebView::show-notification
Created attachment 407471 [details]
Comment on attachment 407471 [details]
Maybe this could allow us to unskip some of http/tests/notifications ?
(In reply to Philippe Normand from comment #3)
> Comment on attachment 407471 [details]
> Maybe this could allow us to unskip some of http/tests/notifications ?
Probably, I'll give it a try before landing.
Regarding layout tests:
- All the tests under http/tests/notifications/ pass.
- All but one under imported/w3c/web-platform-tests/notifications/ pass, too.
gives a timeout, I'll mark it “[ Timeout Pass ]” for now.
Created attachment 407501 [details]
Patch for landing
Committed r266297: <https://trac.webkit.org/changeset/266297>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 407501 [details].