AudioParam's minValue / maxValue are ignored, we never use them to actually clamp the AudioParam's values.
Created attachment 407433 [details] Patch
Created attachment 407436 [details] Patch
Comment on attachment 407436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407436&action=review > Source/WebCore/Modules/webaudio/AudioParamTimeline.h:55 > + float valueForContextTime(BaseAudioContext&, float defaultValue, float minValue, float maxValue, bool& hasValue); Seems like we’d use optional for this instead of a "hasValue" out argument if we were writing the code rather than importing code already written. > Source/WebCore/Modules/webaudio/AudioParamTimeline.h:62 > + float valuesForTimeRange(Seconds startTime, Seconds endTime, float defaultValue, float minValue, float maxValue, float* values, unsigned numberOfValues, double sampleRate, double controlRate); Eventually such a large number of arguments starts calling for use of a structure.
Created attachment 407445 [details] Patch
Committed r266270: <https://trac.webkit.org/changeset/266270> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407445 [details].
<rdar://problem/67914254>