Bug 215903 - AudioParam does not need to store its values as double
Summary: AudioParam does not need to store its values as double
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-08-27 15:36 PDT by Chris Dumez
Modified: 2020-08-27 16:49 PDT (History)
10 users (show)

See Also:

Attachments
Patch (8.30 KB, patch)
2020-08-27 15:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.58 KB, patch)
2020-08-27 16:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.58 KB, patch)
2020-08-27 16:40 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-27 15:36:17 PDT 
AudioParam does not need to store its values as double. float precision is sufficient for WebAudio values and we end up casting these values to float anyway.
Comment 1 Chris Dumez 2020-08-27 15:37:57 PDT 
Created attachment 407428 [details]
Patch
Comment 2 Darin Adler 2020-08-27 15:59:11 PDT 
Comment on attachment 407428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407428&action=review

> Source/WebCore/Modules/webaudio/AudioParam.h:85
> +    unsigned units() const { return 0; }

Maybe change to a static member function for now since it just returns a constant; eventually delete it.
Comment 3 Chris Dumez 2020-08-27 16:39:17 PDT 
Created attachment 407434 [details]
Patch
Comment 4 Chris Dumez 2020-08-27 16:40:38 PDT 
Created attachment 407435 [details]
Patch
Comment 5 Chris Dumez 2020-08-27 16:48:37 PDT 
Comment on attachment 407435 [details]
Patch

Clearing flags on attachment: 407435

Committed r266263: <https://trac.webkit.org/changeset/266263>
Comment 6 Chris Dumez 2020-08-27 16:48:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-08-27 16:49:24 PDT 
<rdar://problem/67905259>