Bug 215902 - Remove the feature flag for capped cookies set in 3rd-party CNAME cloaked HTTP responses and add ITP debug logging
Summary: Remove the feature flag for capped cookies set in 3rd-party CNAME cloaked HTT...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-27 15:07 PDT by John Wilander
Modified: 2020-08-27 19:33 PDT (History)
2 users (show)

See Also:

Attachments
Patch (27.22 KB, patch)
2020-08-27 15:22 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (27.25 KB, patch)
2020-08-27 17:04 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2020-08-27 15:07:24 PDT 
We should remove the feature flag for capped expiries of cookies set in 3rd-party CNAME cloaked HTTP responses and add ITP debug logging for when such capping happens.
Comment 1 John Wilander 2020-08-27 15:08:30 PDT 
<rdar://problem/66699731>
Comment 2 John Wilander 2020-08-27 15:22:19 PDT 
Created attachment 407427 [details]
Patch
Comment 3 John Wilander 2020-08-27 17:04:49 PDT 
Created attachment 407439 [details]
Patch
Comment 4 John Wilander 2020-08-27 17:05:19 PDT 
Trying to fix the non-Cocoa builds.
Comment 5 Brent Fulgham 2020-08-27 17:10:48 PDT 
Comment on attachment 407439 [details]
Patch

Lots of nice code removal. R=me
Comment 6 John Wilander 2020-08-27 18:09:53 PDT 
It seems these two tests may have to be rebased for Windows:

streams/reference-implementation/transform-stream-errors.html
streams/reference-implementation/transform-stream.html

They now get a text diff saying Can't find variable: TransformStream.
Comment 7 John Wilander 2020-08-27 19:23:11 PDT 
Comment on attachment 407439 [details]
Patch

Thanks for the review, Brent!
Comment 8 EWS 2020-08-27 19:33:00 PDT 
Committed r266268: <https://trac.webkit.org/changeset/266268>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407439 [details].