WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
215902
Remove the feature flag for capped cookies set in 3rd-party CNAME cloaked HTTP responses and add ITP debug logging
https://bugs.webkit.org/show_bug.cgi?id=215902
Summary
Remove the feature flag for capped cookies set in 3rd-party CNAME cloaked HTT...
John Wilander
Reported
2020-08-27 15:07:24 PDT
We should remove the feature flag for capped expiries of cookies set in 3rd-party CNAME cloaked HTTP responses and add ITP debug logging for when such capping happens.
Attachments
Patch
(27.22 KB, patch)
2020-08-27 15:22 PDT
,
John Wilander
no flags
Details
Formatted Diff
Diff
Patch
(27.25 KB, patch)
2020-08-27 17:04 PDT
,
John Wilander
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
John Wilander
Comment 1
2020-08-27 15:08:30 PDT
<
rdar://problem/66699731
>
John Wilander
Comment 2
2020-08-27 15:22:19 PDT
Created
attachment 407427
[details]
Patch
John Wilander
Comment 3
2020-08-27 17:04:49 PDT
Created
attachment 407439
[details]
Patch
John Wilander
Comment 4
2020-08-27 17:05:19 PDT
Trying to fix the non-Cocoa builds.
Brent Fulgham
Comment 5
2020-08-27 17:10:48 PDT
Comment on
attachment 407439
[details]
Patch Lots of nice code removal. R=me
John Wilander
Comment 6
2020-08-27 18:09:53 PDT
It seems these two tests may have to be rebased for Windows: streams/reference-implementation/transform-stream-errors.html streams/reference-implementation/transform-stream.html They now get a text diff saying Can't find variable: TransformStream.
John Wilander
Comment 7
2020-08-27 19:23:11 PDT
Comment on
attachment 407439
[details]
Patch Thanks for the review, Brent!
EWS
Comment 8
2020-08-27 19:33:00 PDT
Committed
r266268
: <
https://trac.webkit.org/changeset/266268
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 407439
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug