Bug 215889 - [webkitpy] Use webkitcorepy's auto installer for moz* packages
Summary: [webkitpy] Use webkitcorepy's auto installer for moz* packages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-27 09:03 PDT by Jonathan Bedard
Modified: 2020-09-23 07:35 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.44 KB, patch)
2020-08-27 09:17 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (4.46 KB, patch)
2020-09-21 13:10 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (4.46 KB, patch)
2020-09-21 13:16 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (4.47 KB, patch)
2020-09-21 13:58 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-08-27 09:03:18 PDT
Part of removing webkitpy's autoinstaller in favor of webkitcorepy's.
Comment 1 Radar WebKit Bug Importer 2020-08-27 09:03:36 PDT
<rdar://problem/67877935>
Comment 2 Jonathan Bedard 2020-08-27 09:17:26 PDT
Created attachment 407407 [details]
Patch
Comment 3 Jonathan Bedard 2020-09-21 13:10:48 PDT
Created attachment 409309 [details]
Patch
Comment 4 Jonathan Bedard 2020-09-21 13:16:38 PDT
Created attachment 409311 [details]
Patch
Comment 5 Aakash Jain 2020-09-21 13:17:52 PDT
Comment on attachment 409309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409309&action=review

rs=me

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:-31
> -import webkitpy.thirdparty.autoinstalled.mozlog

These imports aren't required anymore?
Comment 6 Jonathan Bedard 2020-09-21 13:20:35 PDT
(In reply to Aakash Jain from comment #5)
> Comment on attachment 409309 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409309&action=review
> 
> rs=me
> 
> > Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:-31
> > -import webkitpy.thirdparty.autoinstalled.mozlog
> 
> These imports aren't required anymore?

They aren't valid any more. The old autoinstaller required that you preface an autoinstalled library with 'webkitpy.thirdparty.autoinstalled' to trigger the auto-instillation. The new one will pick up any import of the library. That means that in this case, "from mozlog import structuredlog" will install mozlog for us.
Comment 7 Jonathan Bedard 2020-09-21 13:58:25 PDT
Created attachment 409317 [details]
Patch for landing
Comment 8 EWS 2020-09-21 14:20:22 PDT
Committed r267368: <https://trac.webkit.org/changeset/267368>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409317 [details].