Bug 215874 - Update DynamicsCompressorNode::process() to use AudioParam::finalValue()
Summary: Update DynamicsCompressorNode::process() to use AudioParam::finalValue()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-08-26 16:45 PDT by Chris Dumez
Modified: 2020-08-26 20:44 PDT (History)
10 users (show)

See Also:

Attachments
Patch (14.63 KB, patch)
2020-08-26 17:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-26 16:45:02 PDT 
Update DynamicsCompressorNode::process() to use AudioParam::finalValue(). All of DynamicsCompressorNode use k-rate (in fixed mode) so we should be using AudioParam::finalValue() unconditionally.
Comment 1 Chris Dumez 2020-08-26 17:18:15 PDT 
Created attachment 407361 [details]
Patch
Comment 2 EWS 2020-08-26 20:43:39 PDT 
Committed r266219: <https://trac.webkit.org/changeset/266219>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407361 [details].
Comment 3 Radar WebKit Bug Importer 2020-08-26 20:44:17 PDT 
<rdar://problem/67848266>