Bug 215871 – Switch to class method for smart insert/delete

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Switch to class method for smart insert/delete

[Megan Gardner]

Created attachment 407349 [details]
Patch

[Megan Gardner]

<rdar://problem/67281776>

[Megan Gardner]

Created attachment 407352 [details]
Patch

[Darin Adler]

Comment on attachment 407352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407352&action=review

> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:120
> -    return [[UIKeyboardImpl sharedInstance] smartInsertDeleteIsEnabled];
> +    return [UIKeyboardImpl smartInsertDeleteIsEnabled];

This is available in all versions we need to support?

[Megan Gardner]

Created attachment 407356 [details]
Patch

[Darin Adler]

Comment on attachment 407356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407356&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:309
> +#if PLATFORM(IOS_FAMILY)

What’s the case of UIKit use with PLATFORM(IOS_FAMILY) false? I think there isn’t one because even Catalyst is part of that.

[Megan Gardner]

Created attachment 407360 [details]
Patch

[Darin Adler]

Comment on attachment 407360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407360&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:309
> -- (BOOL)smartInsertDeleteIsEnabled;
> ++ (BOOL)smartInsertDeleteIsEnabled;

Let me ask my original question again: Is this available in UIKit in the older versions of the various platforms that WebKit currently supports? Like if it was new to iOS 14 it would not be OK to use it unconditionally yet.

[Megan Gardner]

Created attachment 407362 [details]
Patch

[Darin Adler]

Comment on attachment 407362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407362&action=review

> Source/WTF/wtf/PlatformHave.h:714
> +#define UIKEYBOARDIMPL_SMARTINSERTDELETE_CLASS_METHOD 1

This needs a HAVE_ prefix.

[Megan Gardner]

Created attachment 407363 [details]
Patch

[Tim Horton]

Comment on attachment 407363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407363&action=review

> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:120
> +#if PLATFORM(HAVE_UIKEYBOARDIMPL_SMARTINSERTDELETE_CLASS_METHOD)

This is still not right. PLATFORM(HAVE_...)

[Darin Adler]

Comment on attachment 407363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407363&action=review

>> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:120
>> +#if PLATFORM(HAVE_UIKEYBOARDIMPL_SMARTINSERTDELETE_CLASS_METHOD)
> 
> This is still not right. PLATFORM(HAVE_...)

Oh, right:

   #if HAVE(

[Megan Gardner]

Created attachment 407416 [details]
Patch

[EWS]

Committed r266404: <https://trac.webkit.org/changeset/266404>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407416 [details].