Bug 215850 - Code cleanup and consistent naming in AXIsolatedTree classes, no change in behavior.
Summary: Code cleanup and consistent naming in AXIsolatedTree classes, no change in be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-26 07:14 PDT by Andres Gonzalez
Modified: 2020-08-26 11:10 PDT (History)
10 users (show)

See Also:

Attachments
Patch (14.66 KB, patch)
2020-08-26 07:22 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-08-26 07:14:39 PDT 
Code cleanup and consistent naming in AXIsolatedTree classes, no change in behavior.
Comment 1 Andres Gonzalez 2020-08-26 07:22:22 PDT 
Created attachment 407295 [details]
Patch
Comment 2 EWS 2020-08-26 10:24:45 PDT 
Committed r266171: <https://trac.webkit.org/changeset/266171>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407295 [details].
Comment 3 Radar WebKit Bug Importer 2020-08-26 10:25:15 PDT 
<rdar://problem/67813458>
Comment 4 Darin Adler 2020-08-26 11:10:02 PDT 
Comment on attachment 407295 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407295&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:456
> +        m_propertyMap.set(propertyName, value);

We should return here and add a WTFMove to value. Would improve performance a bit.