Bug 215840 - [JSC] Implement Intl.DateTimeFormat fractionalSecondDigits
Summary: [JSC] Implement Intl.DateTimeFormat fractionalSecondDigits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 213425
  Show dependency tree / graph
 
Reported: 2020-08-25 23:21 PDT by Yusuke Suzuki
Modified: 2020-08-26 09:49 PDT (History)
9 users (show)

See Also:

Attachments
Patch (15.81 KB, patch)
2020-08-26 00:34 PDT, Yusuke Suzuki 		ross.kirsling: review+
Details | Formatted Diff | Diff
Patch (15.87 KB, patch)
2020-08-26 00:53 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-08-25 23:21:02 PDT 
https://github.com/tc39/ecma402/pull/347
Comment 1 Yusuke Suzuki 2020-08-25 23:23:11 PDT 
This looks like about to be landed. We should support it.
Comment 2 Yusuke Suzuki 2020-08-26 00:34:56 PDT 
Created attachment 407277 [details]
Patch
Comment 3 Ross Kirsling 2020-08-26 00:40:57 PDT 
Comment on attachment 407277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407277&action=review

Easy-peasy! :)

> Source/JavaScriptCore/builtins/DatePrototype.js:52
> +            options.fractionalSecondDigits == @undefined

===, right?

> Source/JavaScriptCore/builtins/DatePrototype.js:168
> +            options.fractionalSecondDigits == @undefined

Ditto.

> JSTests/stress/intl-datetimeformat.js:704
> +       "fractionalSecondDigits",

nit: Indentation is off here (and also further above), though it doesn't matter much in a test file.
Comment 4 Yusuke Suzuki 2020-08-26 00:52:29 PDT 
Comment on attachment 407277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407277&action=review

Thanks!

>> Source/JavaScriptCore/builtins/DatePrototype.js:52
>> +            options.fractionalSecondDigits == @undefined
> 
> ===, right?

Oops! Thanks.

>> Source/JavaScriptCore/builtins/DatePrototype.js:168
>> +            options.fractionalSecondDigits == @undefined
> 
> Ditto.

Fixed.

>> JSTests/stress/intl-datetimeformat.js:704
>> +       "fractionalSecondDigits",
> 
> nit: Indentation is off here (and also further above), though it doesn't matter much in a test file.

Fixed.
Comment 5 Yusuke Suzuki 2020-08-26 00:53:44 PDT 
Created attachment 407281 [details]
Patch

Patch for landing
Comment 6 EWS 2020-08-26 09:48:38 PDT 
Committed r266170: <https://trac.webkit.org/changeset/266170>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407281 [details].
Comment 7 Radar WebKit Bug Importer 2020-08-26 09:49:13 PDT 
<rdar://problem/67811354>