Bug 215828 – Web Inspector: button for Inspector^2 doesn't work without setting default for DeveloperExtrasEnabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

This should be automatically set up and require no extra config.

[Blaze Burg]

Created attachment 407310 [details]
Patch

[Devin Rousso]

Comment on attachment 407310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407310&action=review

r=me, nice solution :)

> Source/WebInspectorUI/ChangeLog:11
> +        Drive-by: because the Inspector^2 button is text-only and has no
> +        .name element, the '2' button does not become dimmed when the
> +        window is inactive, unlike every other item in the tab bar.
> +        Fix this by coloring the text-only button similar to tab labels.

IMO, since this is an engineering only feature I don't think we need to care about this 😅

at the very least please put the styles in Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css so it isn't shipped (and maybe include a comment in UserInterface/Views/ButtonNavigationItem.css so that we know there's some related styles elsewhere)

[Blaze Burg]

(In reply to Devin Rousso from comment #2)
> Comment on attachment 407310 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=407310&action=review
> 
> r=me, nice solution :)
> 
> > Source/WebInspectorUI/ChangeLog:11
> > +        Drive-by: because the Inspector^2 button is text-only and has no
> > +        .name element, the '2' button does not become dimmed when the
> > +        window is inactive, unlike every other item in the tab bar.
> > +        Fix this by coloring the text-only button similar to tab labels.
> 
> IMO, since this is an engineering only feature I don't think we need to care
> about this 😅
> 
> at the very least please put the styles in
> Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css so it isn't shipped
> (and maybe include a comment in UserInterface/Views/ButtonNavigationItem.css
> so that we know there's some related styles elsewhere)

OK

[Blaze Burg]

Created attachment 407375 [details]
Patch

[EWS]

/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Blaze Burg]

Created attachment 407377 [details]
Patch

[EWS]

Committed r266225: <https://trac.webkit.org/changeset/266225>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407377 [details].

[Radar WebKit Bug Importer]

<rdar://problem/67855023>