Bug 215825 - [Mac,EME] Netflix.com shows HDCP error for all streams
Summary: [Mac,EME] Netflix.com shows HDCP error for all streams
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-25 14:17 PDT by Jer Noble
Modified: 2020-08-26 10:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.16 KB, patch)
2020-08-25 14:26 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (7.16 KB, patch)
2020-08-25 14:57 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-08-25 14:17:41 PDT 
[Mac,EME] Netflix.com shows HDCP error for all streams
Comment 1 Jer Noble 2020-08-25 14:22:40 PDT 
<rdar://problem/66948621>
Comment 2 Jer Noble 2020-08-25 14:26:54 PDT 
Created attachment 407231 [details]
Patch
Comment 3 Eric Carlson 2020-08-25 14:35:51 PDT 
Comment on attachment 407231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407231&action=review

> Source/WebCore/ChangeLog:11
> +        displayID. This causes AVFoundation to do a "lowest common level  of support" rather than a specific display check.

s/level  of support/level of support/

> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:1388
> +bool CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID(AVContentKeyRequest  *request, PlatformDisplayID displayID) const

s/AVContentKeyRequest  *request/AVContentKeyRequest *request/

> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:1390
> +    // willOutputBeObscuredDueToInsufficientExternalProtectionForDisplays will always return "YES" prior

s/return "YES" prior/return "YES" prior to/

> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:1400
> +    // and to query the HDCP level required by each AVContentKeyRequest, and do the comparison between th two in the

s/between th two/between the two/
Comment 4 Peng Liu 2020-08-25 14:43:35 PDT 
Comment on attachment 407231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407231&action=review

> Source/WebCore/ChangeLog:13
> +        AVContentKeyRequest will report that it's output is restricted if any non-HDCP compliant display is attached.

s/it's/its
Comment 5 Jer Noble 2020-08-25 14:57:07 PDT 
Created attachment 407237 [details]
Patch for landing
Comment 6 EWS 2020-08-26 10:57:11 PDT 
Committed r266176: <https://trac.webkit.org/changeset/266176>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407237 [details].