Bug 215788 - Clean up deprecated and unused SPI to set HSTS storage on ProcessPoolConfiguration
Summary: Clean up deprecated and unused SPI to set HSTS storage on ProcessPoolConfigur...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on: 215802
Blocks:
  Show dependency tree / graph
 
Reported: 2020-08-24 17:54 PDT by Alex Christensen
Modified: 2020-08-25 11:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.80 KB, patch)
2020-08-24 17:59 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (13.42 KB, patch)
2020-08-24 19:37 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (9.95 KB, patch)
2020-08-25 10:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-08-24 17:54:55 PDT 
Clean up deprecated and unused SPI to set HSTS storage on ProcessPoolConfiguration
Comment 1 Alex Christensen 2020-08-24 17:59:52 PDT 
Created attachment 407152 [details]
Patch
Comment 2 Alex Christensen 2020-08-24 19:37:59 PDT 
Created attachment 407161 [details]
Patch
Comment 3 Alex Christensen 2020-08-24 19:46:00 PDT 
Comment on attachment 407161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407161&action=review

> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:-193
> -    if (m_sessionID.isEphemeral() || hstsStorageDirectory().isNull())

I guess this wasn't dead code, but it needs to come through the NetworkSessionCreationParameters instead of the NetworkProcessCreationParameters now.  Could someone implement that for GTK/WPE?
Comment 4 Alex Christensen 2020-08-25 10:17:16 PDT 
Soup part of this was done well in r266112
Comment 5 Alex Christensen 2020-08-25 10:20:50 PDT 
Created attachment 407204 [details]
Patch
Comment 6 EWS 2020-08-25 11:06:48 PDT 
Committed r266133: <https://trac.webkit.org/changeset/266133>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407204 [details].
Comment 7 Radar WebKit Bug Importer 2020-08-25 11:07:18 PDT 
<rdar://problem/67747536>