WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
215777
[ews] set references header in email so as to group similar emails together
https://bugs.webkit.org/show_bug.cgi?id=215777
Summary
[ews] set references header in email so as to group similar emails together
Aakash Jain
Reported
2020-08-24 12:21:40 PDT
We should set 'references' header in ews email notifications, so as the mail client can group similar emails together. We should set same 'references' header for all the emails we want to be grouped together.
Attachments
Patch
(6.19 KB, patch)
2020-08-24 12:32 PDT
,
Aakash Jain
jbedard
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2020-08-24 12:32:14 PDT
Created
attachment 407123
[details]
Patch
Jonathan Bedard
Comment 2
2020-08-24 15:02:10 PDT
Comment on
attachment 407123
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=407123&action=review
> Tools/BuildSlaveSupport/ews-build/steps.py:1493 > + send_email_to_patch_author(patch_author, email_subject, email_text, patch_id)
Looks good, although for
https://bugs.webkit.org/show_bug.cgi?id=215776
, don't we need to do this for test failure emails too? And should test failures and build failures be in the same thread?
Jonathan Bedard
Comment 3
2020-08-24 15:08:58 PDT
Comment on
attachment 407123
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=407123&action=review
>> Tools/BuildSlaveSupport/ews-build/steps.py:1493 >> + send_email_to_patch_author(patch_author, email_subject, email_text, patch_id) > > Looks good, although for
https://bugs.webkit.org/show_bug.cgi?id=215776
, don't we need to do this for test failure emails too? And should test failures and build failures be in the same thread?
Nevermind, just noticed that on line 2167
Aakash Jain
Comment 4
2020-08-24 15:45:12 PDT
Committed
r266088
: <
https://trac.webkit.org/changeset/266088
>
Radar WebKit Bug Importer
Comment 5
2020-08-24 15:46:19 PDT
<
rdar://problem/67703820
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug