Bug 215777 - [ews] set references header in email so as to group similar emails together
Summary: [ews] set references header in email so as to group similar emails together
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 215220
  Show dependency treegraph
 
Reported: 2020-08-24 12:21 PDT by Aakash Jain
Modified: 2020-08-24 15:46 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.19 KB, patch)
2020-08-24 12:32 PDT, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-08-24 12:21:40 PDT
We should set 'references' header in ews email notifications, so as the mail client can group similar emails together. We should set same 'references' header for all the emails we want to be grouped together.
Comment 1 Aakash Jain 2020-08-24 12:32:14 PDT
Created attachment 407123 [details]
Patch
Comment 2 Jonathan Bedard 2020-08-24 15:02:10 PDT
Comment on attachment 407123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407123&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:1493
> +            send_email_to_patch_author(patch_author, email_subject, email_text, patch_id)

Looks good, although for https://bugs.webkit.org/show_bug.cgi?id=215776, don't we need to do this for test failure emails too? And should test failures and build failures be in the same thread?
Comment 3 Jonathan Bedard 2020-08-24 15:08:58 PDT
Comment on attachment 407123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407123&action=review

>> Tools/BuildSlaveSupport/ews-build/steps.py:1493
>> +            send_email_to_patch_author(patch_author, email_subject, email_text, patch_id)
> 
> Looks good, although for https://bugs.webkit.org/show_bug.cgi?id=215776, don't we need to do this for test failure emails too? And should test failures and build failures be in the same thread?

Nevermind, just noticed that on line 2167
Comment 4 Aakash Jain 2020-08-24 15:45:12 PDT
Committed r266088: <https://trac.webkit.org/changeset/266088>
Comment 5 Radar WebKit Bug Importer 2020-08-24 15:46:19 PDT
<rdar://problem/67703820>