Bug 215762 - Non-special URLs are not idempotent
Summary: Non-special URLs are not idempotent
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2020-08-24 00:12 PDT by Anne van Kesteren
Modified: 2020-10-11 13:04 PDT (History)
9 users (show)

See Also:

Patch (23.56 KB, patch)
2020-09-29 10:20 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (24.30 KB, patch)
2020-09-30 19:17 PDT, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2020-08-24 00:12:32 PDT
See https://github.com/whatwg/url/pull/505 for the URL Standard change and https://github.com/web-platform-tests/wpt/pull/25113 for new tests.
Comment 1 Radar WebKit Bug Importer 2020-08-31 00:13:18 PDT
Comment 2 Alex Christensen 2020-08-31 20:12:56 PDT
Sorry I missed a lot of the discussion here.  Idempotence is good, but adding a dot is a little strange.  Were alternative solutions considered?
Comment 3 Anne van Kesteren 2020-09-01 00:01:14 PDT
Yeah, see the discussion in https://github.com/whatwg/url/issues/415. But solution seemed best (and had precedent in an implementation) as it would not lead to the introduction of a host where there was none.
Comment 4 Alex Christensen 2020-09-29 10:20:57 PDT
Created attachment 410014 [details]
Comment 5 Alex Christensen 2020-09-29 10:22:19 PDT
Comment on attachment 410014 [details]

This first patch is close but not quite perfect.  It's tricky in an implementation that serializes while parsing and tries to use the same string if possible.
Comment 6 Alex Christensen 2020-09-30 19:17:29 PDT
Created attachment 410190 [details]
Comment 7 Alex Christensen 2020-10-01 10:05:55 PDT