WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
21576
Fix a race in fast/history/history_reload.html
https://bugs.webkit.org/show_bug.cgi?id=21576
Summary
Fix a race in fast/history/history_reload.html
Pam Greene (IRC:pamg)
Reported
2008-10-13 12:34:49 PDT
The fast/history/history_reload.html test has a potential race condition caused by higher-resolution timers. I don't know exactly what threshold it takes to expose the problem, but it's worth removing anyway. Each time the subframe loads, the onclose handler calls layoutTestController.notifyDone via setTimeout(0). If that gets fired before the history.go() completes, the test appears to have failed. One solution is to always use two passes in the test, and not complete until the second one.
Attachments
Fixed test
(1.97 KB, patch)
2008-10-13 12:47 PDT
,
Pam Greene (IRC:pamg)
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pam Greene (IRC:pamg)
Comment 1
2008-10-13 12:47:23 PDT
Created
attachment 24322
[details]
Fixed test No change to expected results.
Pam Greene (IRC:pamg)
Comment 2
2008-10-17 11:08:06 PDT
Landed in
r37657
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug