Bug 215759 - Avoid timeout when http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html fails
Summary: Avoid timeout when http/tests/websocket/tests/hybi/stop-on-resume-in-error-ha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-23 13:37 PDT by Lauro Moura
Modified: 2020-08-23 14:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.41 KB, patch)
2020-08-23 13:39 PDT, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-08-23 13:37:03 PDT
In bug215638, http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html times out as the close callback is called but it does not finish the test run, waiting for the error callback that is never called. This may lead to meaningful information being lost in the test runs, like what the actual failures were.
Comment 1 Lauro Moura 2020-08-23 13:39:18 PDT
Created attachment 407081 [details]
Patch
Comment 2 EWS 2020-08-23 14:21:13 PDT
Committed r266049: <https://trac.webkit.org/changeset/266049>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407081 [details].
Comment 3 Radar WebKit Bug Importer 2020-08-23 14:22:16 PDT
<rdar://problem/67650454>