Bug 215758 - ScrollLatchingState::startedGestureAtScrollLimit() is always false; remove it
Summary: ScrollLatchingState::startedGestureAtScrollLimit() is always false; remove it
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-23 11:15 PDT by Simon Fraser (smfr)
Modified: 2023-07-10 11:52 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.35 KB, patch)
2020-08-23 11:16 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-08-23 11:15:42 PDT 
ScrollLatchingState::startedGestureAtScrollLimit() is always false; remove it
Comment 1 Simon Fraser (smfr) 2020-08-23 11:16:44 PDT 
Created attachment 407076 [details]
Patch
Comment 2 Darin Adler 2020-08-23 11:33:29 PDT 
Comment on attachment 407076 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407076&action=review

> Source/WebCore/page/scrolling/ScrollLatchingState.h:59
> +    // FIXME: scrollablearea.

What does this comment mean? Could you write just a few more words in it?
Comment 3 Simon Fraser (smfr) 2020-08-23 11:34:59 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 407076 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=407076&action=review
> 
> > Source/WebCore/page/scrolling/ScrollLatchingState.h:59
> > +    // FIXME: scrollablearea.
> 
> What does this comment mean? Could you write just a few more words in it?

I'll remove it for this patch.
Comment 4 Radar WebKit Bug Importer 2020-08-30 11:16:36 PDT 
<rdar://problem/68034808>
Comment 5 Ahmad Saleem 2023-07-08 16:07:17 PDT 
I tried to search for 'startedGestureAtScrollLimit' and 'setStartedGestureAtScrollLimit', which this patch was removing but didn't manage to find it.

Also unable to find commit as well (weird).

@Simon & @Darin - do we need to keep this open?
Comment 6 Simon Fraser (smfr) 2023-07-10 11:52:39 PDT 
This landed in https://commits.webkit.org/228689@main