Bug 215753 – Do not use undefined default param in CSSStyleDeclaration.idl

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Rob Buis]

Do not use undefined default parameter value in CSSStyleDeclaration.idl, instead use no explicit default
parameter at all. This means a zero length String will be used, which will be more efficient when using
the cssPropertyID helper method, as well as less error-prone.

[Rob Buis]

Created attachment 407054 [details]
Patch

[Darin Adler]

Comment on attachment 407054 [details]
Patch

Could we have added a tests? Or is there no way to detect that we are failing to look up "undefined" vs. failing to look up a null string?

[Rob Buis]

(In reply to Darin Adler from comment #2)
> Comment on attachment 407054 [details]
> Patch
> 
> Could we have added a tests? Or is there no way to detect that we are
> failing to look up "undefined" vs. failing to look up a null string?

I think the only way is through timing both lookups, and asserting that the null string lookup (early exit) will take less time than looking up "undefined". I personally thing this is a bit overkill but let me know if you want me to add such a test.

[EWS]

Committed r266046: <https://trac.webkit.org/changeset/266046>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407054 [details].

[Radar WebKit Bug Importer]

<rdar://problem/67640590>