Bug 215750 – Console object's @@toStringTag should be "console" instead of "Console"

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

Console object's @@toStringTag should be "console" instead of "Console"

[Yusuke Suzuki]

Created attachment 407042 [details]
Patch

[Ross Kirsling]

Comment on attachment 407042 [details]
Patch

r=me, given that CSS[@@toStringTag] will be addressed in a later patch.

We should probably link https://github.com/web-platform-tests/wpt/pull/24717 in the ChangeLog though.

[Yusuke Suzuki]

(In reply to Ross Kirsling from comment #2)
> Comment on attachment 407042 [details]
> Patch
> 
> r=me, given that CSS[@@toStringTag] will be addressed in a later patch.
> 
> We should probably link https://github.com/web-platform-tests/wpt/pull/24717
> in the ChangeLog though.

Sounds good!

[Yusuke Suzuki]

Created attachment 407044 [details]
Patch

Patch for landing

[Yusuke Suzuki]

Created attachment 407045 [details]
Patch

Patch for landing

[Alexey Shvayka]

(In reply to Ross Kirsling from comment #2)
> Comment on attachment 407042 [details]
> Patch
> 
> r=me, given that CSS[@@toStringTag] will be addressed in a later patch.

For `CSS`, it might get tricky since `CodeGeneratorJS.pm` has no notion of namespace objects.
Currently, `CSS.prototype[Symbol.toStringTag] === "CSS"`, but it's wrong since `CSS` shouldn't be a function.
Making `CSS` an ordinary object will take some tweaking to code generator (an extra attribute) + might break some sites depending on `typeof CSS === "function"` check.
So instead, we may consider adding Symbol.toStringTag in [CustomToJSObject] or something, until Chromium will ship `CSS` as ordinary object change.

Tests for namespace objects: https://github.com/web-platform-tests/wpt/pull/24724.

[Alexey Shvayka]

(In reply to Alexey Shvayka from comment #6)
> So instead, we may consider adding Symbol.toStringTag in [CustomToJSObject]
> or something, until Chromium will ship `CSS` as ordinary object change.

Or we can just hardcode `$interfaceName eq "CSS"` at CodeGeneratorJS.pm:4445 and add it there, but it won't look nice.

[Yusuke Suzuki]

I'll land it with testapi rebaseline.

[Yusuke Suzuki]

(In reply to Alexey Shvayka from comment #7)
> (In reply to Alexey Shvayka from comment #6)
> > So instead, we may consider adding Symbol.toStringTag in [CustomToJSObject]
> > or something, until Chromium will ship `CSS` as ordinary object change.
> 
> Or we can just hardcode `$interfaceName eq "CSS"` at CodeGeneratorJS.pm:4445
> and add it there, but it won't look nice.

Yeah, I think, supporting `namespace` in IDL would be the best way :)

[Yusuke Suzuki]

Committed r266030: <https://trac.webkit.org/changeset/266030>

[Radar WebKit Bug Importer]

<rdar://problem/67620195>