I'll send a patch. About misleading-indentation, the warnings are: ../../Source/JavaScriptCore/b3/B3Validate.cpp:112:105: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] do { if (dominators.dominates(valueOwner.get(child), valueOwner.get(value))) break; fail("../../Source/JavaScriptCore/b3/B3Validate.cpp", 112, __PRETTY_FUNCTION__, "dominators.dominates(value Owner.get(child), valueOwner.get(value))", toCString ("at ", *value, "->", pointerDump(child))); } while (false); ^ ../../Source/JavaScriptCore/b3/B3Validate.cpp:111:17: note: previous statement is here else ^ ../../Source/JavaScriptCore/b3/B3Validate.cpp:618:68: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] do { if (value.value()->type().isInt()) break; fail("../../Source/JavaScriptCore/b3/B3Validate.cpp", 618, __PRETTY_FUNCTION__, "value.value()->type().isInt()", toCString ("At ", *context, ": ", value)); } while (false); ^ ../../Source/JavaScriptCore/b3/B3Validate.cpp:617:17: note: previous statement is here else ^ ../../Source/JavaScriptCore/b3/B3Validate.cpp:623:70: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] do { if (value.value()->type().isFloat()) break; fail("../../Source/JavaScriptCore/b3/B3Validate.cpp", 623, __PRETTY_FUNCTION__, "value.value()->type().isFloat()", toCString ("At ", *context, ": ", value)); } while (false); ^ ../../Source/JavaScriptCore/b3/B3Validate.cpp:622:17: note: previous statement is here else ^ 3 warnings generated. [1395/3591] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-23a5fd0e-16.cpp.o In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-23a5fd0e-16.cpp:2: ../../Source/JavaScriptCore/b3/air/AirValidate.cpp:90:57: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] do { if (!inst.isTerminal()) break; fail("../../Source/JavaScriptCore/b3/air/AirValidate.cpp", 90, __PRETTY_FUNCTION__, "!inst.isTerminal()", toCString ("At ", inst, " in ", *block)); } while (false); ^ ../../Source/JavaScriptCore/b3/air/AirValidate.cpp:89:17: note: previous statement is here else ^ 1 warning generated. [1447/3591] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-0e543b66-1.cpp.o In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-0e543b66-1.cpp:3: In file included from ../../Source/JavaScriptCore/interpreter/CallFrame.cpp:36: ../../Source/JavaScriptCore/wasm/WasmContextInlines.h:66:9: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] instance = inst; ^ ../../Source/JavaScriptCore/wasm/WasmContextInlines.h:58:5: note: previous statement is here if (inst) ^ 1 warning generated. [1448/3591] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-1.cpp.o In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-1.cpp:1: In file included from ../../Source/JavaScriptCore/jit/AssemblyHelpers.cpp:41: ../../Source/JavaScriptCore/wasm/WasmContextInlines.h:66:9: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] instance = inst; ^ ../../Source/JavaScriptCore/wasm/WasmContextInlines.h:58:5: note: previous statement is here if (inst) ^ 1 warning generated. As I'm not sure what to do about this, I propose to disable this warning, as these reports are false-positive due to macro usage, IIUC. But I'm open to proposals :)
Created attachment 406936 [details] Patch
Created attachment 406942 [details] Patch
Created attachment 406943 [details] Patch
Comment on attachment 406943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406943&action=review > Source/WebCore/ChangeLog:15 > + matchingRuns assignment. I have no idea how this was supposed to work? It worked like bool matchingRuns = (matchingRuns = checkForMatchingNonTextRuns(...)); Assignment operator returns assigned value so matchingRuns was assigned twice
Committed r266025: <https://trac.webkit.org/changeset/266025>