Bug 215696 - Cocoa WebSocketTask should expose WebSocket server extensions
Summary: Cocoa WebSocketTask should expose WebSocket server extensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-20 05:55 PDT by youenn fablet
Modified: 2020-08-24 07:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.33 KB, patch)
2020-08-20 06:00 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.99 KB, patch)
2020-08-20 08:37 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (7.41 KB, patch)
2020-08-24 07:21 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-08-20 05:55:11 PDT 
Cocoa WebSocketTask should expose WebSocket server extensions
Comment 1 youenn fablet 2020-08-20 06:00:19 PDT 
Created attachment 406926 [details]
Patch
Comment 2 youenn fablet 2020-08-20 08:37:55 PDT 
Created attachment 406932 [details]
Patch
Comment 3 Darin Adler 2020-08-21 09:44:32 PDT 
Comment on attachment 406926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406926&action=review

> Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm:99
> +    auto *response = [m_task response];

I suggest just auto here. I don’t think the * adds anything.
Comment 4 youenn fablet 2020-08-24 07:21:32 PDT 
Created attachment 407101 [details]
Patch for landing
Comment 5 EWS 2020-08-24 07:58:03 PDT 
Committed r266057: <https://trac.webkit.org/changeset/266057>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407101 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-24 07:59:15 PDT 
<rdar://problem/67679855>