http/tests/websocket/tests/hybi/close-on-* tests are not interoperable
Created attachment 406921 [details] Patch
Comment on attachment 406921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406921&action=review Seems OK but I have a big question. > LayoutTests/ChangeLog:10 > + Before the patch, tests were not passing in Chrome, Firefox and NSURLSession WebSocket code path. > + This was due to the fact the web socket script is using try/finally and the closure of the connection is not raising an exception > + while it is for Chrome, Firefox and NSURLSession WebSocket code path. Why should we change our test to smooth over differences between WebSocket implementations? Don’t we want to uncover such interoperability problems and highlight them? > LayoutTests/ChangeLog:11 > + Change the WebSocket server script to more reliablly send the socket message at closing time of the connection. typo: reliably
> Why should we change our test to smooth over differences between WebSocket > implementations? Don’t we want to uncover such interoperability problems and > highlight them? Tests were written to check various things, for instance that navigating is closing the connection. Smoothing the differences keep the initial goal of the tests intact. I'll add a specific test dedicated to track the difference between legacy WebSocket code path and the other implementations when closing.
Created attachment 407099 [details] Patch for landing
Uploaded corresponding test in https://bugs.webkit.org/show_bug.cgi?id=215766.
Committed r266059: <https://trac.webkit.org/changeset/266059> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407099 [details].
<rdar://problem/67680019>