CTFontGetPhysicalSymbolicTraits() is faster than CTFontCopyPhysicalFont()/CTFontGetSymbolicTraits()

[Myles C. Maxfield]

We can take a shortcut.

[Myles C. Maxfield]

Created attachment 406910 [details]
Patch

[Myles C. Maxfield]

This patch needs to modify CoreTextSPI.h.

[Myles C. Maxfield]

<rdar://problem/51631817>

[Myles C. Maxfield]

Created attachment 408142 [details]
Patch

[Darin Adler]

Comment on attachment 408142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408142&action=review

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:858
> +            RetainPtr<CTFontRef> fontForSynthesisComputation = font;

auto fontForSynthesisComputation = retainPtr(font);

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h:57
> +enum class ShouldComputePhysicalTraits : uint8_t {
> +    Yes,
> +    No
> +};

I suggest bool instead of uint8_t, No before Yes, and putting this on a single line instead of vertically on 4 lines.

[Myles C. Maxfield]

Created attachment 408153 [details]
Patch for committing

[EWS]

Committed r266690: <https://trac.webkit.org/changeset/266690>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408153 [details].