RESOLVED FIXED 21567
prepare-ChangeLog should know how to find functions in JavaScript files 
https://bugs.webkit.org/show_bug.cgi?id=21567
Summary prepare-ChangeLog should know how to find functions in JavaScript files
Timothy Hatcher
Reported 2008-10-13 10:23:55 PDT
Since most of the Web Inspector is JavaScript, we should make prepare-ChangeLog work with JavaScripts.
Attachments
Proposed patch (8.26 KB, patch)
2008-10-13 10:46 PDT, Timothy Hatcher 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2008-10-13 10:46:45 PDT
Created attachment 24315 [details] Proposed patch
David Kilzer (:ddkilzer)
Comment 2 2008-10-14 11:39:57 PDT
Comment on attachment 24315 [details] Proposed patch # Only look for function names in .c files. Please fix this comment (I know it's been there forever). Perhaps to "...in certain source files."? Also, please declare "sub get_function_line_ranges_for_javascript($$)" at the top of the source file. Otherwise looks great! r=me with the above changes.
Timothy Hatcher
Comment 3 2008-10-14 12:17:31 PDT
Landed in r37588.
Note You need to log in before you can comment on or make changes to this bug.