Bug 215669 - AudioBufferSourceNode should use "final" values for playbackRate and detune
Summary: AudioBufferSourceNode should use "final" values for playbackRate and detune
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency treegraph
 
Reported: 2020-08-19 16:52 PDT by Chris Dumez
Modified: 2020-08-20 16:16 PDT (History)
10 users (show)

See Also:


Attachments
Patch (9.79 KB, patch)
2020-08-19 16:54 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (10.41 KB, patch)
2020-08-20 10:32 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-19 16:52:45 PDT
AudioBufferSourceNode should use "final" values for playbackRate and detune to take into account changes to the AudioParamTimeline (for example, when AudioBufferSourceNode.playbackRate.setValueAtTime() is called).
Comment 1 Chris Dumez 2020-08-19 16:54:51 PDT
Created attachment 406887 [details]
Patch
Comment 2 Eric Carlson 2020-08-20 09:27:20 PDT
Looks like this is causing lots of asserts in tests.
Comment 3 Chris Dumez 2020-08-20 10:32:39 PDT
Created attachment 406944 [details]
Patch
Comment 4 Chris Dumez 2020-08-20 15:52:55 PDT
(In reply to Eric Carlson from comment #2)
> Looks like this is causing lots of asserts in tests.

Yes, turns out you can only call finalValue() from the AudioThread. This is fixed now.
Comment 5 EWS 2020-08-20 16:15:23 PDT
Committed r265981: <https://trac.webkit.org/changeset/265981>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406944 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-20 16:16:18 PDT
<rdar://problem/67513315>