Bug 215663 – Blob is missing text() & arrayBuffer() operations

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Blob is missing text() & arrayBuffer() operations:
- https://w3c.github.io/FileAPI/#blob-section

[Chris Dumez]

Created attachment 406873 [details]
Patch

[Chris Dumez]

Created attachment 406877 [details]
Patch

[Geoffrey Garen]

Comment on attachment 406877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406877&action=review

r=me

> Source/WebCore/fileapi/NetworkSendQueue.cpp:74
> +    blobLoaderPtr->start(blob, m_document.get(), FileReaderLoader::ReadAsArrayBuffer);

Could use m_queue.last() here instead of blobLoaderPtr. Not sure if that's obviously better; but taking a raw pointer to a UniqueRef smells bad.

> Source/WebCore/page/ShareDataReader.cpp:58
> +        blobLoaderPtr->start(*blob, document, FileReaderLoader::ReadAsArrayBuffer);

Here too.

[Chris Dumez]

For the record, this was reported via Twitter here:
https://twitter.com/baldand/status/1295769537367990273

[Chris Dumez]

Comment on attachment 406877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406877&action=review

>> Source/WebCore/fileapi/NetworkSendQueue.cpp:74
>> +    blobLoaderPtr->start(blob, m_document.get(), FileReaderLoader::ReadAsArrayBuffer);
> 
> Could use m_queue.last() here instead of blobLoaderPtr. Not sure if that's obviously better; but taking a raw pointer to a UniqueRef smells bad.

Sadly, the queue contains a Variant type so it is not convenient to do what you suggest. I will apply your suggestion to ShareDataReader.cpp though.

[Chris Dumez]

Created attachment 406884 [details]
Patch

[EWS]

Committed r265908: <https://trac.webkit.org/changeset/265908>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406884 [details].

[Radar WebKit Bug Importer]

<rdar://problem/67436725>

[Tetsuharu Ohzeki [UTC+9]]

*** Bug 213168 has been marked as a duplicate of this bug. ***