Bug 215655 – REGRESSION (r263729): Carousel freezes on "fourth page"/fourth click on right arrow on netflix.com

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Wenson Hsieh]

<rdar://problem/65845979>

[Wenson Hsieh]

Created attachment 406954 [details]
Patch

[Dean Jackson]

Comment on attachment 406954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406954&action=review

> Source/WebCore/ChangeLog:11
> +        `translate` CSS properties to a container `div`, and adds a `transitionend` event listener which the page

did you mean `transition`?

[Wenson Hsieh]

Comment on attachment 406954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406954&action=review

>> Source/WebCore/ChangeLog:11
>> +        `translate` CSS properties to a container `div`, and adds a `transitionend` event listener which the page
> 
> did you mean `transition`?

Whoops, yes I did! Fixed.

[Simon Fraser (smfr)]

Comment on attachment 406954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406954&action=review

> Source/WebCore/ChangeLog:11
> +        `translate` CSS properties to a container `div`, and adds a `transitionend` event listener which the page

Did you mean `translate` here, or `transition`?

> LayoutTests/animations/animation-followed-by-two-transitions.html:45
> +            await UIHelper.delayFor(60);

Why 60ms?

[Wenson Hsieh]

Comment on attachment 406954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406954&action=review

>> LayoutTests/animations/animation-followed-by-two-transitions.html:45
>> +            await UIHelper.delayFor(60);
> 
> Why 60ms?

So when I originally wrote this, I noticed that some delay was needed to cause the test to fail without the change in this patch. After some experimentation I thought that I needed to match the duration of the transition that is ending (60ms), but now after more digging, I realized that this is not the case.

In order for the test to exercise the bug, I need to wait long enough here for the CSSTransition that was created as a result of adding the "transition" class to complete (i.e. `DocumentTimeline::transitionDidComplete`). It seems this call happens during the next rendering update after `AnimationTimeline::updateCSSAnimationsForElement`, which happens during the next rendering update after replacing the "transition" class with "no-transition".

As such, it should be sufficient to replace this hard-coded delay with two `await UIHelper.renderingUpdate();`s.

[Wenson Hsieh]

Created attachment 406969 [details]
Patch

[EWS]

Committed r265985: <https://trac.webkit.org/changeset/265985>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406969 [details].

[Antoine Quint]

*** Bug 215159 has been marked as a duplicate of this bug. ***

[Antoine Quint]

*** Bug 217061 has been marked as a duplicate of this bug. ***