accessibility/mac/select-element-selection-with-optgroups.html Test is a flaky failure according to history on macOS. Failures have been most recently on Debug. Last failure on Release was at r261505. Will setup expectations across macOS. There is no indication of first occurrence as failures reach the limit of history going back as far as limit of results webpage. Maybe related to https://bugs.webkit.org/show_bug.cgi?id=175341 History: https://results.webkit.org/?suite=layout-tests&test=accessibility%2Fmac%2Fselect-element-selection-with-optgroups.html&limit=50000 Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/accessibility/mac/select-element-selection-with-optgroups-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/accessibility/mac/select-element-selection-with-optgroups-actual.txt @@ -10,7 +10,7 @@ PASS selectElement.selectedChildrenCount became 1 PASS selectElement.selectedChildAtIndex(0).isEqual(option2) is true PASS selectElement.selectedChildrenCount became 1 -PASS selectElement.selectedChildAtIndex(0).isEqual(option3) is true +FAIL selectElement.selectedChildAtIndex(0).isEqual(option3) should be true. Was false. PASS successfullyParsed is true TEST COMPLETE
<rdar://problem/67406148>
Test expectation while investigated: https://trac.webkit.org/changeset/265862/webkit
Created attachment 411016 [details] Patch
Comment on attachment 411016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411016&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:959 > + Vector<RefPtr<AXCoreObject>> axObjects; can we use the map function in Vector to make this use less code? > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:154 > + result.reserveCapacity(objects.size()); can we use a map function to reduce code?
Created attachment 411249 [details] Patch
(In reply to chris fleizach from comment #4) > Comment on attachment 411016 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411016&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:959 > > + Vector<RefPtr<AXCoreObject>> axObjects; > > can we use the map function in Vector to make this use less code? Done. > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:154 > > + result.reserveCapacity(objects.size()); > > can we use a map function to reduce code? Done.
Committed r268454: <https://trac.webkit.org/changeset/268454> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411249 [details].