RESOLVED FIXED Bug 215644
WebSocketChannel::didClose should correctly compute whether a closing handshake was received 
https://bugs.webkit.org/show_bug.cgi?id=215644
Summary WebSocketChannel::didClose should correctly compute whether a closing handsha...
youenn fablet
Reported 2020-08-19 05:15:24 PDT
WebSocketChannel::didClose should correctly compute whether a closing handshake was received
Attachments
Patch (2.34 KB, patch)
2020-08-19 05:19 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-08-19 05:19:22 PDT
Created attachment 406840 [details] Patch
Darin Adler
Comment 2 2020-08-19 08:25:04 PDT
Comment on attachment 406840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406840&action=review > Source/WebKit/ChangeLog:8 > + Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled. Where is that code path enabled? Why aren’t we seeing the failure in any bot?
youenn fablet
Comment 3 2020-08-19 08:31:19 PDT
Comment on attachment 406840 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406840&action=review >> Source/WebKit/ChangeLog:8 >> + Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled. > > Where is that code path enabled? Why aren’t we seeing the failure in any bot? This code path is off by default on all bots. It can be enabled in Safari as an experimental feature. We are working on reducing the test results between the two code paths before enabling this code path.
EWS
Comment 4 2020-08-19 08:39:10 PDT
Committed r265856: <https://trac.webkit.org/changeset/265856> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406840 [details].
Radar WebKit Bug Importer
Comment 5 2020-08-19 08:40:21 PDT
<rdar://problem/67405340>
Note You need to log in before you can comment on or make changes to this bug.