Bug 215644 - WebSocketChannel::didClose should correctly compute whether a closing handshake was received
Summary: WebSocketChannel::didClose should correctly compute whether a closing handsha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-19 05:15 PDT by youenn fablet
Modified: 2020-08-19 20:39 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.34 KB, patch)
2020-08-19 05:19 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-08-19 05:15:24 PDT
WebSocketChannel::didClose should correctly compute whether a closing handshake was received
Comment 1 youenn fablet 2020-08-19 05:19:22 PDT
Created attachment 406840 [details]
Patch
Comment 2 Darin Adler 2020-08-19 08:25:04 PDT
Comment on attachment 406840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406840&action=review

> Source/WebKit/ChangeLog:8
> +        Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled.

Where is that code path enabled? Why aren’t we seeing the failure in any bot?
Comment 3 youenn fablet 2020-08-19 08:31:19 PDT
Comment on attachment 406840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406840&action=review

>> Source/WebKit/ChangeLog:8
>> +        Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled.
> 
> Where is that code path enabled? Why aren’t we seeing the failure in any bot?

This code path is off by default on all bots. It can be enabled in Safari as an experimental feature.
We are working on reducing the test results between the two code paths before enabling this code path.
Comment 4 EWS 2020-08-19 08:39:10 PDT
Committed r265856: <https://trac.webkit.org/changeset/265856>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406840 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-19 08:40:21 PDT
<rdar://problem/67405340>