Without https://bugs.webkit.org/show_bug.cgi?id=213761, we need Rosetta specific test expectation parsing. I'm adding a temporary Rosetta special case on Mac so that we can retain coverage for Intel Macs on Big Sur.
<rdar://problem/67353771>
Created attachment 406824 [details] Patch
Comment on attachment 406824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406824&action=review Could we include or convert at least *one* expectation using this mechanism in the same patch that adds it? > Tools/Scripts/webkitpy/port/mac_unittest.py:274 > + def test_rosetta_expecrtations(self): Typo "expecrtations"
(In reply to Darin Adler from comment #3) > Comment on attachment 406824 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406824&action=review > > Could we include or convert at least *one* expectation using this mechanism > in the same patch that adds it? > > > Tools/Scripts/webkitpy/port/mac_unittest.py:274 > > + def test_rosetta_expecrtations(self): > > Typo "expecrtations" Yes, intended to include an expectation file, but forgot to svn add it
(In reply to Jonathan Bedard from comment #4) > Yes, intended to include an expectation file, but forgot to svn add it Is this a whole separate file? I’m getting less and less enamored of separate TestExpectations files -- there are just too many and hard to understand their relationship -- and more with syntax within the one big Mac TestExpectation file.
(In reply to Darin Adler from comment #5) > (In reply to Jonathan Bedard from comment #4) > > Yes, intended to include an expectation file, but forgot to svn add it > > Is this a whole separate file? > > I’m getting less and less enamored of separate TestExpectations files -- > there are just too many and hard to understand their relationship -- and > more with syntax within the one big Mac TestExpectation file. Totally agree! <https://bugs.webkit.org/show_bug.cgi?id=213761> covers exactly that, this is intended as a stop-gap so we can defend Rosetta in the mean time. Hoping to get to that bug in September, since it also block Catalyst layout tests.
Created attachment 406826 [details] Patch
Committed r265846: <https://trac.webkit.org/changeset/265846> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406826 [details].