Bug 215624 - ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext
Summary: ScriptProcessNode should only run script asynchronously if the audio context ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-08-18 13:50 PDT by Chris Dumez
Modified: 2020-08-18 15:52 PDT (History)
10 users (show)

See Also:

Attachments
Patch (9.08 KB, patch)
2020-08-18 14:09 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.15 KB, patch)
2020-08-18 14:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-18 13:50:14 PDT 
ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext. If the context is an OfflineAudioContext, then it should pause processing until the script has finished execution. This aligns our behavior with Blink and helps us pass more WPT tests.
Comment 1 Chris Dumez 2020-08-18 14:09:07 PDT 
Created attachment 406808 [details]
Patch
Comment 2 Eric Carlson 2020-08-18 14:30:52 PDT 
Comment on attachment 406808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406808&action=review

> Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp:214
> +                    // De-reference to match the ref() call in process().

Nit: it is a little odd to have this comment only on the second `deref()`
Comment 3 Chris Dumez 2020-08-18 14:56:21 PDT 
Created attachment 406816 [details]
Patch
Comment 4 EWS 2020-08-18 15:51:23 PDT 
Committed r265836: <https://trac.webkit.org/changeset/265836>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406816 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-18 15:52:16 PDT 
<rdar://problem/67358588>