Bug 215619 – [macOS] Move stepper painting code off of Carbon API

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

This will ensure the stepper has an appropriate appearance in dark mode.

[Aditya Keerthi]

<rdar://problem/41936617>

[Aditya Keerthi]

Created attachment 406802 [details]
Patch

[Darin Adler]

Comment on attachment 406802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406802&action=review

We should figure out how to make test coverage for this.

> Source/WebCore/platform/mac/ThemeMac.mm:637
> +    ControlStates::States states = controlStates.states();

Consider auto here instead of writing out the type ControlStates::States

> Source/WebCore/platform/mac/ThemeMac.mm:672
> +        (__bridge NSString *)kCUIWidgetKey: (__bridge NSString *)kCUIWidgetButtonLittleArrows,
> +        (__bridge NSString *)kCUISizeKey: coreUISize,
> +        (__bridge NSString *)kCUIStateKey: coreUIState,
> +        (__bridge NSString *)kCUIValueKey: (states & ControlStates::SpinUpState) ? @1 : @0,
> +        (__bridge NSString *)kCUIIsFlippedKey : @NO,
> +        (__bridge NSString *)kCUIScaleKey : @1,
> +        (__bridge NSString *)kCUIMaskOnlyKey : @NO

Mixed formatting here about whether the ":" has a space before it or not.

[Aditya Keerthi]

Created attachment 406817 [details]
Patch for landing

[Aditya Keerthi]

(In reply to Darin Adler from comment #3)
> Comment on attachment 406802 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=406802&action=review
> 
> We should figure out how to make test coverage for this.

I added a reference mismatch test to verify that the stepper has a different appearance under dark mode.

[EWS]

Committed r265860: <https://trac.webkit.org/changeset/265860>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406817 [details].

[Aditya Keerthi]

Reopening to attach new patch.

[Aditya Keerthi]

Created attachment 406947 [details]
Patch

[Aditya Keerthi]

Uploaded a patch to the wrong bug.