Bug 215617 - Make some small improvements involving sorting
Summary: Make some small improvements involving sorting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-18 11:47 PDT by Darin Adler
Modified: 2020-08-22 09:14 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.78 KB, patch)
2020-08-18 11:51 PDT, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-08-18 11:47:26 PDT 
Make some small improvements involving sorting
Comment 1 Darin Adler 2020-08-18 11:51:20 PDT 
Created attachment 406797 [details]
Patch
Comment 2 Darin Adler 2020-08-18 13:02:35 PDT 
Comment on attachment 406797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406797&action=review

> Source/WebCore/page/PerformanceObserver.cpp:94
> +            if (oldEnd != end) {

Just realized I don’t think this if statement is needed. I think both algorithms below are super-efficient when the ranges are empty.
Comment 3 Darin Adler 2020-08-22 09:13:17 PDT 
Committed r266027: <https://trac.webkit.org/changeset/266027>
Comment 4 Radar WebKit Bug Importer 2020-08-22 09:14:13 PDT 
<rdar://problem/67617539>