Convert runtime flag to setting for lazy image loading.
Created attachment 406789 [details] Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
<rdar://problem/67740399>
Created attachment 407384 [details] Patch
Created attachment 407391 [details] Patch
Created attachment 407398 [details] Patch
Created attachment 407400 [details] Patch
Created attachment 407457 [details] Patch
Created attachment 407459 [details] Patch
Comment on attachment 407459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407459&action=review > Source/WebKit/Shared/WebPreferences.yaml:-2048 > - category: experimental Why removing the experimental feature?
Created attachment 407466 [details] Patch
Found 1 new test failure: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html
Created attachment 407536 [details] Patch
Created attachment 407595 [details] Patch
Committed r266350: <https://trac.webkit.org/changeset/266350> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407595 [details].
Reverted r266350 for reason: Revision is causing a constant crash on both macOS and iOS Committed r266358: <https://trac.webkit.org/changeset/266358>
Created attachment 407609 [details] Patch
Comment on attachment 407609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407609&action=review > Source/WebCore/ChangeLog:8 > + Convert runtime flag to setting for lazy image loading. This is missing the "why".
(In reply to Simon Fraser (smfr) from comment #18) > Comment on attachment 407609 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407609&action=review > > > Source/WebCore/ChangeLog:8 > > + Convert runtime flag to setting for lazy image loading. > > This is missing the "why". Because Sam asked for it :) But I think Sam (partially) ended up implementing it himself: https://bug-215981-attachments.webkit.org/attachment.cgi?id=407610
Created attachment 407613 [details] Patch
Created attachment 407664 [details] Patch
Committed r266408: <https://trac.webkit.org/changeset/266408> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407664 [details].
Reverted r266408 for reason: Revision caused constant crashes on iOS and macOS Committed r266446: <https://trac.webkit.org/changeset/266446>
Why did EWS not show crashes?
(In reply to Simon Fraser (smfr) from comment #24) > Why did EWS not show crashes? What Simon says. You have to give a bit more information about this, the bots are green and I can't reproduce any problems locally. Is this maybe related to a certain macOs version? Any backtraces?
This is most probably https://bugs.webkit.org/show_bug.cgi?id=216007
(In reply to youenn fablet from comment #26) > This is most probably https://bugs.webkit.org/show_bug.cgi?id=216007 Thanks Youenn. I was aware of this problem and added a line to skip it for now in the patches that landed: +imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html [ Skip ] Is skipping not the right thing? Should it be marked as Crash?
(In reply to Rob Buis from comment #27) > (In reply to youenn fablet from comment #26) > > This is most probably https://bugs.webkit.org/show_bug.cgi?id=216007 > > Thanks Youenn. I was aware of this problem and added a line to skip it for > now in the patches that landed: > +imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img- > element/image-loading-lazy-slow.html [ Skip ] > > Is skipping not the right thing? Should it be marked as Crash? We should probably first understand why it is crashing before skipping it. Can you repro the issue for this test? If some other test is crashing, it might be some similar test. Hector might be able to provide some more precise information later.
*** Bug 216007 has been marked as a duplicate of this bug. ***
(In reply to youenn fablet from comment #28) > (In reply to Rob Buis from comment #27) > > (In reply to youenn fablet from comment #26) > > > This is most probably https://bugs.webkit.org/show_bug.cgi?id=216007 > > > > Thanks Youenn. I was aware of this problem and added a line to skip it for > > now in the patches that landed: > > +imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img- > > element/image-loading-lazy-slow.html [ Skip ] > > > > Is skipping not the right thing? Should it be marked as Crash? > > We should probably first understand why it is crashing before skipping it. > Can you repro the issue for this test? > > If some other test is crashing, it might be some similar test. > Hector might be able to provide some more precise information later. Yes, I was able to repro and fix is here: https://bugs.webkit.org/show_bug.cgi?id=215998 I think it is cleaner to keep the fix separate since this bug was just about converting, not really changing behaviour.
Created attachment 408448 [details] Patch
Created attachment 408688 [details] Patch
@youenn I upstreamed some of the reftest-wait tests changes to: https://github.com/web-platform-tests/wpt/pull/25513
Created attachment 408704 [details] Patch
Created attachment 408705 [details] Patch
Created attachment 408707 [details] Patch
Created attachment 408727 [details] Patch
Created attachment 408736 [details] Patch
Created attachment 408745 [details] Patch
Created attachment 408800 [details] Patch
Created attachment 408808 [details] Patch
Committed r267083: <https://trac.webkit.org/changeset/267083> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408808 [details].