Bug 215607 – Add support for TransformStream

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Add support for TransformStream

[youenn fablet]

Created attachment 406788 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[youenn fablet]

Created attachment 406791 [details]
Patch

[Sam Weinig]

Comment on attachment 406791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406791&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.h:296
> +    void setTransformStreamAPIEnabled(bool isEnabled) { m_isTransformStreamAPIEnabled = isEnabled; }
> +    bool transformStreamAPIEnabled() const { return m_isTransformStreamAPIEnabled; }

Unless this truly needs to be on the singleton, please use a Setting rather than a global RuntimeEnabledFeature.

[youenn fablet]

(In reply to Sam Weinig from comment #4)
> Comment on attachment 406791 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=406791&action=review
> 
> > Source/WebCore/page/RuntimeEnabledFeatures.h:296
> > +    void setTransformStreamAPIEnabled(bool isEnabled) { m_isTransformStreamAPIEnabled = isEnabled; }
> > +    bool transformStreamAPIEnabled() const { return m_isTransformStreamAPIEnabled; }
> 
> Unless this truly needs to be on the singleton, please use a Setting rather
> than a global RuntimeEnabledFeature.

TransformStream are exposed to Workers, using a setting would require some additional work.

[Sam Weinig]

(In reply to youenn fablet from comment #5)
> (In reply to Sam Weinig from comment #4)
> > Comment on attachment 406791 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=406791&action=review
> > 
> > > Source/WebCore/page/RuntimeEnabledFeatures.h:296
> > > +    void setTransformStreamAPIEnabled(bool isEnabled) { m_isTransformStreamAPIEnabled = isEnabled; }
> > > +    bool transformStreamAPIEnabled() const { return m_isTransformStreamAPIEnabled; }
> > 
> > Unless this truly needs to be on the singleton, please use a Setting rather
> > than a global RuntimeEnabledFeature.
> 
> TransformStream are exposed to Workers, using a setting would require some
> additional work.

ok.

[Alex Christensen]

Comment on attachment 406791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406791&action=review

> LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any.js:319
> +// }, 'writer.abort() inside size() should work');

Why are we commenting all this out?

[youenn fablet]

(In reply to Alex Christensen from comment #7)
> Comment on attachment 406791 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=406791&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any.js:319
> > +// }, 'writer.abort() inside size() should work');
> 
> Why are we commenting all this out?

Ah, right, I forgot to undo these changes.
Tests passes but I will reupload a patch with tests enabled.

[youenn fablet]

ping review

[Radar WebKit Bug Importer]

<rdar://problem/67739054>

[Alex Christensen]

Comment on attachment 406791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406791&action=review

> Source/WebCore/Modules/streams/TransformStream.idl:2
> + * Copyright (C) 2015 Canon Inc.

Is this correct?  Was this implemented in 2015?

> LayoutTests/imported/w3c/web-platform-tests/streams/transform-streams/reentrant-strategies.any.js:41
> +// promise_test(() => {

This needs to not be commented out.

[youenn fablet]

Created attachment 407282 [details]
Patch

[youenn fablet]

Test failures are crashes that do not seem related to this patch

[EWS]

Committed r266228: <https://trac.webkit.org/changeset/266228>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407282 [details].

[Brent Fulgham]

*** Bug 151599 has been marked as a duplicate of this bug. ***