Bug 215596 - [Mac] Unhandled keyDown: events cause a system beep in full screen mode
Summary: [Mac] Unhandled keyDown: events cause a system beep in full screen mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-17 17:02 PDT by Jer Noble
Modified: 2020-08-18 09:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2020-08-17 17:05 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (1.67 KB, patch)
2020-08-18 08:38 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-08-17 17:02:34 PDT 
[Mac] Unhandled keyDown: events cause a system beep in full screen mode
Comment 1 Jer Noble 2020-08-17 17:04:29 PDT 
<rdar://problem/65823962>
Comment 2 Jer Noble 2020-08-17 17:05:19 PDT 
Created attachment 406754 [details]
Patch
Comment 3 Darin Adler 2020-08-17 17:30:38 PDT 
Comment on attachment 406754 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406754&action=review

> Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:229
> +    UNUSED_PARAM(eventMethod);

Comment would be welcome.
Comment 4 Jer Noble 2020-08-18 08:33:03 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 406754 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=406754&action=review
> 
> > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:229
> > +    UNUSED_PARAM(eventMethod);
> 
> Comment would be welcome.

Sure thing. I wavered on whether to add a "why" comment here.
Comment 5 Jer Noble 2020-08-18 08:38:36 PDT 
Created attachment 406787 [details]
Patch for landing
Comment 6 EWS 2020-08-18 09:01:45 PDT 
Committed r265816: <https://trac.webkit.org/changeset/265816>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406787 [details].