Bug 215585 – Develop a mechanism to unsubscribe from ews emails

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Develop a mechanism to unsubscribe from ews emails for patch authors. This is for engineers who prefer not to receive email notifications from ews for the build/test failures on their patches.

[Aakash Jain]

Created attachment 406745 [details]
Patch

[Jonathan Bedard]

Comment on attachment 406745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406745&action=review

> Tools/BuildSlaveSupport/ews-build/emails.json:4
> +  "EMAIL_IDS_TO_UNSUBSCRIBE": []

I'm ok with this, but have we thought about other potential possibilities? Seems like this approach is a bit onerous if the unsubscribe rate is very high.

[Aakash Jain]

(In reply to Jonathan Bedard from comment #2)
> I'm ok with this, but have we thought about other potential possibilities? Seems like this approach is a bit onerous if the unsubscribe rate is very high.
One other approach was to store this information somewhere in Bugzilla, but we might not want this solution to be tightly couple with Bugzilla.

In this approach, one consideration was to make sure that we don't need a Buildbot restart to add any email to unsubscribe list to be effective, which this approach fulfills. Another idea I considered was to fetch emails.json from trac (so that unsubscribe would have been effective immediately, without even updating the local checkout on the server), but that would have been little slower, and any breakage in email.json (by someone's manual commmit) would also cause issue immediately.

I'm open to other ideas.

Also, most likely the unsubscribe rate will settle down few days after starting these emails. Majority of people would be able to decide whether they want to continue receiving the emails or not in a few days.

[Jonathan Bedard]

Comment on attachment 406745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406745&action=review

> Tools/BuildSlaveSupport/ews-build/emails.json:2
> +  "ADMIN_EMAILS": ["[e-mail]", "[e-mail]"],

What do we intend on using this for?

> Tools/BuildSlaveSupport/ews-build/send_email.py:40
> +    except:

Bare except is what's breaking the style rules. Maybe just catch BaseException?

[Aakash Jain]

Created attachment 406786 [details]
Patch

[Aakash Jain]

(In reply to Jonathan Bedard from comment #4)
> > Tools/BuildSlaveSupport/ews-build/emails.json:2
> > +  "ADMIN_EMAILS": ["[e-mail]", "[e-mail]"],
> 
> What do we intend on using this for?
This would be used in subsequent patches to enable email notifications for admin for infrastructure issues (like kill-old-processes failure).
> 
> > Tools/BuildSlaveSupport/ews-build/send_email.py:40
> > +    except:
> 
> Bare except is what's breaking the style rules. Maybe just catch BaseException?
Fixed in updated patch.

[Aakash Jain]

Committed r265817: <https://trac.webkit.org/changeset/265817>

[Radar WebKit Bug Importer]

<rdar://problem/67330693>