Bug 21557 - REGRESSION: generated-layer-scrollbar-crash.html is crashing
Summary: REGRESSION: generated-layer-scrollbar-crash.html is crashing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Major
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-12 11:49 PDT by Darin Adler
Modified: 2008-10-12 15:54 PDT (History)
1 user (show)

See Also:


Attachments
patch (1.65 KB, patch)
2008-10-12 11:58 PDT, Darin Adler
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-10-12 11:49:12 PDT
The regression test is failing because of new code in RenderLayer::styleChanged.
Comment 1 Darin Adler 2008-10-12 11:58:03 PDT
This crash is caused by the code that tries to get the pseudo style for the scroll bar and resizer in RenderLayer::styleChanged. It's being called on a RenderView, which has a document for its element and thus can't be styled. I suspect that's a bug, but it's easy to fix this code to be robust in cases like this, which is what I did.
Comment 2 Darin Adler 2008-10-12 11:58:26 PDT
Created attachment 24304 [details]
patch
Comment 3 Mark Rowe (bdash) 2008-10-12 15:45:38 PDT
Comment on attachment 24304 [details]
patch

r=me
Comment 4 Darin Adler 2008-10-12 15:54:47 PDT
http://trac.webkit.org/changeset/37533