Bug 21556 - non-ASCII digits are allowed in places where only ASCII should be
Summary: non-ASCII digits are allowed in places where only ASCII should be
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Minor
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-12 11:12 PDT by Darin Adler
Modified: 2008-10-12 15:51 PDT (History)
0 users

See Also:

Attachments
patch (120.32 KB, patch)
2008-10-12 13:28 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
patch (58.42 KB, patch)
2008-10-12 13:29 PDT, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2008-10-12 11:12:21 PDT 
We shouldn't have isDigit and digitValue in our Unicode class, because there's no context where we want to support arbitrary Unicode digits. All the places we support digits they need to be ASCII digits only.
Comment 1 Darin Adler 2008-10-12 11:33:31 PDT 
My plan is to remove unused functions from our Unicode headers and also remove used functions that are being used when an ASCII function should be used instead.

    - digitValue is never used except where it should be ASCII-only
    - isDigit is never used except where it should be ASCII-only
    - isFormatChar is unused

As far as I can tell, the other functions are used correctly, so I won't touch them for now.
Comment 2 Darin Adler 2008-10-12 13:28:01 PDT 
Created attachment 24309 [details]
patch
Comment 3 Darin Adler 2008-10-12 13:29:37 PDT 
Created attachment 24310 [details]
patch

Oops, included unrelated changes by accident.
Comment 4 Sam Weinig 2008-10-12 15:25:14 PDT 
Comment on attachment 24310 [details]
patch

r=me, but I think you should land the cleanups separately.
Comment 5 Darin Adler 2008-10-12 15:51:40 PDT 
http://trac.webkit.org/changeset/37531