Bug 215554 - JSDOMConstructorNotConstructable should be a constructor
Summary: JSDOMConstructorNotConstructable should be a constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-16 17:07 PDT by Yusuke Suzuki
Modified: 2020-08-17 00:37 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.40 KB, patch)
2020-08-16 17:08 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2020-08-16 17:12 PDT, Yusuke Suzuki
darin: review+
Details | Formatted Diff | Diff
Patch (190.23 KB, patch)
2020-08-16 22:38 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (364.15 KB, patch)
2020-08-16 23:30 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-08-16 17:07:49 PDT
JSDOMConstructorNotConstructable should be a constructor
Comment 1 Yusuke Suzuki 2020-08-16 17:08:29 PDT
Created attachment 406690 [details]
Patch
Comment 2 Yusuke Suzuki 2020-08-16 17:08:31 PDT
<rdar://problem/65770688>
Comment 3 Yusuke Suzuki 2020-08-16 17:12:37 PDT
Created attachment 406691 [details]
Patch
Comment 4 Darin Adler 2020-08-16 17:18:49 PDT
Comment on attachment 406691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406691&action=review

> LayoutTests/ChangeLog:10
> +        * js/dom/window-is-constructor-expected.txt: Added.
> +        * js/dom/window-is-constructor.html: Added.

Should this be in WPT instead?
Comment 5 Yusuke Suzuki 2020-08-16 22:37:11 PDT
Comment on attachment 406691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406691&action=review

>> LayoutTests/ChangeLog:10
>> +        * js/dom/window-is-constructor.html: Added.
> 
> Should this be in WPT instead?

Sounds good.
Comment 6 Yusuke Suzuki 2020-08-16 22:38:46 PDT
Created attachment 406698 [details]
Patch

Collecting updated expected files
Comment 7 Yusuke Suzuki 2020-08-16 23:30:26 PDT
Created attachment 406699 [details]
Patch

Collecting updated expected files
Comment 8 Yusuke Suzuki 2020-08-17 00:37:19 PDT
Committed r265749: <https://trac.webkit.org/changeset/265749>