Bug 215534 - [webkitcorepy] Autoinstaller is very slow in git-svn checkouts
Summary: [webkitcorepy] Autoinstaller is very slow in git-svn checkouts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-14 22:05 PDT by Jonathan Bedard
Modified: 2020-08-17 12:29 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.17 KB, patch)
2020-08-14 22:09 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-08-14 22:05:00 PDT
Worked for a bit debugging this issue today, and while we never got to the root cause, we did get enough information to determine how to avoid such slowness, which is to avoid running setup.py from a directory in a git-svn checkout.
Comment 1 Radar WebKit Bug Importer 2020-08-14 22:05:18 PDT
<rdar://problem/67120623>
Comment 2 Jonathan Bedard 2020-08-14 22:09:42 PDT
Created attachment 406656 [details]
Patch
Comment 3 Jonathan Bedard 2020-08-14 22:11:21 PDT
Comment on attachment 406656 [details]
Patch

Waiting for Dean, who originally reported the issue with his configuration, to verify this actually fixes things for him.
Comment 4 Jonathan Bedard 2020-08-17 11:43:56 PDT
(In reply to Jonathan Bedard from comment #3)
> Comment on attachment 406656 [details]
> Patch
> 
> Waiting for Dean, who originally reported the issue with his configuration,
> to verify this actually fixes things for him.

Dean verified that this fixed his issue. Seems like setup.py doesn't like running from git-svn checkouts.
Comment 5 Dean Johnson 2020-08-17 12:03:52 PDT
Comment on attachment 406656 [details]
Patch

Unofficial r+; fixes my issue and code / ChangeLog looks good.
Comment 6 EWS 2020-08-17 12:29:06 PDT
Committed r265766: <https://trac.webkit.org/changeset/265766>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406656 [details].