Bug 215533 - [AS Layout Tests] 6 WPT css-backgrounds tests consistently failing
Summary: [AS Layout Tests] 6 WPT css-backgrounds tests consistently failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-14 18:48 PDT by Dean Jackson
Modified: 2020-08-16 12:11 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.50 KB, patch)
2020-08-14 18:55 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2020-08-14 18:48:40 PDT
[AS Layout Tests] 6 WPT css-backgrounds tests consistently failing
Comment 1 Dean Jackson 2020-08-14 18:49:07 PDT
<rdar://66660924>
Comment 2 Dean Jackson 2020-08-14 18:55:21 PDT
Created attachment 406647 [details]
Patch
Comment 3 youenn fablet 2020-08-15 09:32:21 PDT
Comment on attachment 406647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406647&action=review

> Source/WebCore/svg/graphics/SVGImage.cpp:175
> +        return IntSize(300, 150);

Are these values used elsewhere? Is it worth using constants or a specific routine to document/centralize these values?
Comment 4 Dean Jackson 2020-08-16 11:56:30 PDT
Comment on attachment 406647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406647&action=review

>> Source/WebCore/svg/graphics/SVGImage.cpp:175
>> +        return IntSize(300, 150);
> 
> Are these values used elsewhere? Is it worth using constants or a specific routine to document/centralize these values?

They are probably used in a bunch of spots, yeah. We could make a constant.
Comment 5 EWS 2020-08-16 12:11:11 PDT
Committed r265742: <https://trac.webkit.org/changeset/265742>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406647 [details].