Bug 215528 - [JSC] attribute-change transition should not pin Structure
Summary: [JSC] attribute-change transition should not pin Structure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-14 17:40 PDT by Yusuke Suzuki
Modified: 2020-09-11 20:28 PDT (History)
8 users (show)

See Also:

Attachments
Patch (28.95 KB, patch)
2020-08-14 17:41 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (28.98 KB, patch)
2020-08-14 17:51 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (29.25 KB, patch)
2020-08-14 19:20 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (28.35 KB, patch)
2020-08-14 19:23 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Patch (28.31 KB, patch)
2020-08-14 20:23 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-08-14 17:40:43 PDT 
[JSC] attribute-change transition should not pin Structure
Comment 1 Yusuke Suzuki 2020-08-14 17:41:00 PDT 
Created attachment 406637 [details]
Patch
Comment 2 Yusuke Suzuki 2020-08-14 17:51:08 PDT 
Created attachment 406639 [details]
Patch
Comment 3 Yusuke Suzuki 2020-08-14 19:20:01 PDT 
Created attachment 406648 [details]
Patch
Comment 4 Yusuke Suzuki 2020-08-14 19:23:18 PDT 
Created attachment 406649 [details]
Patch
Comment 5 Saam Barati 2020-08-14 19:35:59 PDT 
Comment on attachment 406649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406649&action=review

> Source/JavaScriptCore/runtime/Structure.cpp:492
> +    if (structure->hasBeenDictionary())

maybe just an explanation why this is the way  it is and why it's not profitable to do the other thing
Comment 6 Yusuke Suzuki 2020-08-14 20:23:48 PDT 
Created attachment 406653 [details]
Patch
Comment 7 Radar WebKit Bug Importer 2020-08-21 17:41:13 PDT 
<rdar://problem/67591477>
Comment 8 Yusuke Suzuki 2020-09-11 20:28:18 PDT 
Committed r266969: <https://trac.webkit.org/changeset/266969>