Bug 215523 - Live Web Content processes do not respect accent color if dynamically changed to "multicolor"
Summary: Live Web Content processes do not respect accent color if dynamically changed...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-14 14:36 PDT by Tim Horton
Modified: 2020-08-15 15:53 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.60 KB, patch)
2020-08-14 14:36 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (17.43 KB, patch)
2020-08-14 16:19 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
test logging (19.04 KB, patch)
2020-08-14 18:12 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
test logging (23.30 KB, patch)
2020-08-15 14:47 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (21.69 KB, patch)
2020-08-15 15:11 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-08-14 14:36:27 PDT 
Live Web Content processes do not respect accent color if dynamically changed to "multicolor"
Comment 1 Tim Horton 2020-08-14 14:36:38 PDT 
Created attachment 406622 [details]
Patch
Comment 2 Tim Horton 2020-08-14 14:36:40 PDT 
<rdar://problem/63941133>
Comment 3 Wenson Hsieh 2020-08-14 14:39:58 PDT 
Comment on attachment 406622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406622&action=review

> Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm:80
> +            if (!a && !b)
> +                return true;
> +            return a && [a isEqual:b];

Nit - I have an ever-so-slight preference for `a == b || [a isEqual:b]`, instead of having a separate branch.
Comment 4 Tim Horton 2020-08-14 15:21:48 PDT 
Per Arne kindly pointed out that he added a testing mechanism for this, so I'm writing a test.
Comment 5 Tim Horton 2020-08-14 16:19:01 PDT 
Created attachment 406633 [details]
Patch
Comment 6 Tim Horton 2020-08-14 17:58:44 PDT 
Oh dear, the new test passes for me but not the bots.
Comment 7 Tim Horton 2020-08-14 18:12:47 PDT 
Created attachment 406640 [details]
test logging
Comment 8 Tim Horton 2020-08-15 14:47:19 PDT 
Created attachment 406676 [details]
test logging
Comment 9 Tim Horton 2020-08-15 15:11:20 PDT 
Created attachment 406677 [details]
Patch
Comment 10 EWS 2020-08-15 15:53:45 PDT 
Committed r265740: <https://trac.webkit.org/changeset/265740>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406677 [details].