Bug 215523 – Live Web Content processes do not respect accent color if dynamically changed to "multicolor"

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Live Web Content processes do not respect accent color if dynamically changed to "multicolor"

[Tim Horton]

Created attachment 406622 [details]
Patch

[Tim Horton]

<rdar://problem/63941133>

[Wenson Hsieh]

Comment on attachment 406622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406622&action=review

> Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm:80
> +            if (!a && !b)
> +                return true;
> +            return a && [a isEqual:b];

Nit - I have an ever-so-slight preference for `a == b || [a isEqual:b]`, instead of having a separate branch.

[Tim Horton]

Per Arne kindly pointed out that he added a testing mechanism for this, so I'm writing a test.

[Tim Horton]

Created attachment 406633 [details]
Patch

[Tim Horton]

Oh dear, the new test passes for me but not the bots.

[Tim Horton]

Created attachment 406640 [details]
test logging

[Tim Horton]

Created attachment 406676 [details]
test logging

[Tim Horton]

Created attachment 406677 [details]
Patch

[EWS]

Committed r265740: <https://trac.webkit.org/changeset/265740>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406677 [details].