Bug 215513 - Fix bad check in AudioBufferSourceNode::renderFromBuffer()
Summary: Fix bad check in AudioBufferSourceNode::renderFromBuffer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-08-14 10:35 PDT by Chris Dumez
Modified: 2020-08-14 11:28 PDT (History)
11 users (show)

See Also:

Attachments
Patch (69.06 KB, patch)
2020-08-14 10:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (69.05 KB, patch)
2020-08-14 10:46 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-14 10:35:29 PDT 
Fix bad check in AudioBufferSourceNode::renderFromBuffer() that is causing us to incorrectly output silence and failing many WPT tests.
Comment 1 Chris Dumez 2020-08-14 10:38:06 PDT 
Created attachment 406602 [details]
Patch
Comment 2 Darin Adler 2020-08-14 10:43:43 PDT 
Comment on attachment 406602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406602&action=review

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:249
> +    if (fabs(pitchRate) > virtualDeltaFrames)

std::abs is better than fabs
Comment 3 Chris Dumez 2020-08-14 10:46:59 PDT 
Created attachment 406605 [details]
Patch
Comment 4 EWS 2020-08-14 11:27:15 PDT 
Committed r265683: <https://trac.webkit.org/changeset/265683>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406605 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-14 11:28:19 PDT 
<rdar://problem/67085393>